alamb commented on code in PR #8916:
URL: https://github.com/apache/arrow-rs/pull/8916#discussion_r2607590168
##########
arrow-flight/src/sql/client.rs:
##########
@@ -168,18 +160,14 @@ impl FlightSqlServiceClient<Channel> {
.map_err(|_| ArrowError::ParseError("Cannot parse
header".to_string()))?;
req.metadata_mut().insert("authorization", val);
let req = self.set_request_headers(req)?;
- let resp = self
- .flight_client
- .handshake(req)
- .await
- .map_err(|e| ArrowError::IpcError(format!("Can't handshake
{e}")))?;
+ let resp = self.flight_client.handshake(req).await?;
Review Comment:
I think adding context that the error was happening in the the handshake
(rather than just passing along the generic service laer) was useful context,
but has been lost in this refactoring.
Is there any way to add it back without losing access to the inner tonic
status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
