alamb commented on code in PR #8953:
URL: https://github.com/apache/arrow-rs/pull/8953#discussion_r2608137856
##########
arrow-select/src/interleave.rs:
##########
@@ -312,6 +314,47 @@ fn interleave_struct(
Ok(Arc::new(struct_array))
}
+fn interleave_list<O: OffsetSizeTrait>(
+ values: &[&dyn Array],
+ indices: &[(usize, usize)],
+ field: &FieldRef,
+) -> Result<ArrayRef, ArrowError> {
+ let interleaved = Interleave::<'_, GenericListArray<O>>::new(values,
indices);
+
+ let mut child_indices = Vec::new();
+ let mut offsets = Vec::with_capacity(indices.len() + 1);
+ offsets.push(O::from_usize(0).unwrap());
+
+ for (a, b) in indices {
Review Comment:
other code in this module uses the names `(array, row)` as clearer names for
these two variables
For example
https://github.com/apache/arrow-rs/blob/36392c141db0e99e84c2fb8c8b1a786d8cf96d54/arrow-select/src/interleave.rs#L371
I suggest we make this kernel consistent too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
