kou commented on code in PR #48333:
URL: https://github.com/apache/arrow/pull/48333#discussion_r2608230452
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3033,146 +3033,30 @@ function(build_absl)
set(ABSL_VENDORED
TRUE
PARENT_SCOPE)
- set(ABSL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/absl_fc-install")
- set(ABSL_PREFIX
- "${ABSL_PREFIX}"
- PARENT_SCOPE)
if(CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION
VERSION_GREATER_EQUAL 13.0)
string(APPEND CMAKE_CXX_FLAGS " -include stdint.h")
endif()
fetchcontent_declare(absl
+ ${FC_DECLARE_COMMON_OPTIONS} OVERRIDE_FIND_PACKAGE
URL ${ABSL_SOURCE_URL}
URL_HASH "SHA256=${ARROW_ABSL_BUILD_SHA256_CHECKSUM}")
prepare_fetchcontent()
- # We have to enable Abseil install to generate abslConfig.cmake
- # so google-cloud-cpp can find Abseil through ExternalProject_Add. Our
expectation
- # is that this will not be necessary once google-cloud-cpp supports
FetchContent.
- set(ABSL_ENABLE_INSTALL ON)
+ set(ABSL_ENABLE_INSTALL OFF)
Review Comment:
```suggestion
# We have to enable Abseil install to add Abseil targets to an export set.
# But we don't install Abseil by EXCLUDE_FROM_ALL.
set(ABSL_ENABLE_INSTALL ON)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
