alamb commented on code in PR #8977:
URL: https://github.com/apache/arrow-rs/pull/8977#discussion_r2608820797
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -1337,6 +1437,24 @@ mod tests {
assert!(out.is_finite() && out.is_sign_negative());
}
+ #[test]
+ fn test_num_traits() {
+ let value = i256::from_i128(-5);
+ assert_eq!(
+ <i256 as CheckedNeg>::checked_neg(&value),
+ Some(i256::from_i128(5))
+ );
+
+ assert_eq!(
Review Comment:
Thank you for these tests -- can we also test the others (checked_sub, for
example)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
