asubiotto commented on PR #8978: URL: https://github.com/apache/arrow-rs/pull/8978#issuecomment-3641173761
Updated with the optimized non-nullable code path. I also updated this PR with two correctness fixes: 1) If keys are nullable from the input but no nulls were found, we now return a null buffer that is fully valid. We were using a `None` null buffer before. Are these two semantically equivalent? 2) In the case that the dictionaries to interleave share an underlying values slice and there is overflow, the fallback path would panic. I now changed `should_merge_dictionary_values` to also return whether key overflow is detected and use the general `interleave_fallback` path in that case. Added a test for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
