tobixdev commented on code in PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#discussion_r2609967966


##########
arrow-select/src/take.rs:
##########


Review Comment:
   Maybe one note for this change. As I understand it, some take kernels are 
using `to_usize` while others are using `as_usize`. I've now used `as_usize` as 
it is also used in the `take_native` kernel.
   
   Is there any guidelines on which operation we should use?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to