ODukhno commented on code in PR #8762:
URL: https://github.com/apache/arrow-rs/pull/8762#discussion_r2611494866
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -283,7 +300,7 @@ impl Sbbf {
/// Write the bloom filter data (header and then bitset) to the output.
This doesn't
/// flush the writer in order to boost performance of bulk writing all
blocks. Caller
/// must remember to flush the writer.
- pub(crate) fn write<W: Write>(&self, mut writer: W) -> Result<(),
ParquetError> {
+ pub fn write<W: Write>(&self, mut writer: W) -> Result<(), ParquetError> {
Review Comment:
@alamb , are you ok if I initiate new pull request? Rose will not be able to
work on this change anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
