alamb commented on code in PR #8912:
URL: https://github.com/apache/arrow-rs/pull/8912#discussion_r2611924269
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -11866,4 +11866,60 @@ mod tests {
// Verify the run-ends were cast correctly (run ends at 3, 6, 9)
assert_eq!(run_array.run_ends().values(), &[3i64, 6i64, 9i64]);
}
+
+ #[test]
+ fn test_string_dicts_to_binary_view() {
Review Comment:
I verified that these tests cover the fix by running them without the
changes in this PR and they fail as expected
```
---- cast::tests::test_binary_dicts_to_string_view stdout ----
thread 'cast::tests::test_binary_dicts_to_string_view' (16945850) panicked
at arrow-cast/src/cast/mod.rs:12222:72:
called `Result::unwrap()` on an `Err` value: ComputeError("Internal Error:
Cannot cast Utf8View to StringArray of expected type")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- cast::tests::test_string_dicts_to_binary_view stdout ----
thread 'cast::tests::test_string_dicts_to_binary_view' (16946091) panicked
at arrow-cast/src/cast/mod.rs:12194:74:
called `Result::unwrap()` on an `Err` value: ComputeError("Internal Error:
Cannot cast BinaryView to BinaryArray of expected type")
failures:
cast::tests::test_binary_dicts_to_string_view
cast::tests::test_string_dicts_to_binary_view
test result: FAILED. 288 passed; 2 failed; 0 ignored; 0 measured; 0 filtered
out; finished in 0.02s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
