nealrichardson commented on code in PR #48262:
URL: https://github.com/apache/arrow/pull/48262#discussion_r2611951642
##########
r/tests/testthat/test-dplyr-funcs-string.R:
##########
@@ -899,51 +899,44 @@ test_that("str_like", {
collect(),
df
)
+
# with namespacing
compare_dplyr_binding(
.input |>
- mutate(x = stringr::str_like(x, "baz")) |>
+ mutate(x_like = stringr::str_like(x, "baz")) |>
+ mutate(x_ilike = stringr::str_ilike(x, "foo%")) |>
collect(),
df
)
# Match - entire string
compare_dplyr_binding(
.input |>
- mutate(x = str_like(x, "Foo and bar")) |>
+ mutate(x_like = str_like(x, "foo and bar")) |>
+ mutate(x_ilike = str_ilike(x, "foo and bar")) |>
Review Comment:
Is it relevant that the casing changed in the diff (capital F before)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
