nealrichardson commented on code in PR #48297:
URL: https://github.com/apache/arrow/pull/48297#discussion_r2611975126
##########
r/tools/nixlibs.R:
##########
@@ -357,18 +345,11 @@ determine_binary_from_stderr <- function(errs) {
} else if (header_not_found("openssl/opensslv", errs)) {
lg("OpenSSL not found")
return(NULL)
- } else if (any(grepl("OpenSSL version too old", errs))) {
- lg("OpenSSL found but version >= 1.0.2 is required for some features")
+ } else if (any(grepl("OpenSSL version must be 3.0 or greater", errs))) {
+ lg("OpenSSL found but version >= 3.0.0 is required")
return(NULL)
- # Else, determine which other binary will work
- } else if (any(grepl("Using OpenSSL version 1.0", errs))) {
- if (on_macos) {
- lg("OpenSSL 1.0 is not supported on macOS")
- return(NULL)
- }
- lg("Found libcurl and OpenSSL < 1.1")
- return("openssl-1.0")
- } else if (any(grepl("Using OpenSSL version 3", errs))) {
+ } else if (any(grepl("Using OpenSSL version 3", errs)) || is.null(attr(errs,
"status"))) {
Review Comment:
I think we can remove the "Using OpenSSL version 3" test now (here and in
the test program above), right? If the test program is successful, it has found
openssl >= 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
