lidavidm commented on code in PR #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771#discussion_r2612209838
##########
go/adbc/driver/databricks/database.go:
##########
Review Comment:
Ideally we could prohibit overlap between URI and other options
##########
go/adbc/driver/databricks/docs/databricks.md:
##########
Review Comment:
This docs format (and license header) do not apply to the upstream project
##########
go/adbc/driver/databricks/driver_test.go:
##########
@@ -336,6 +355,12 @@ func TestDatabricks(t *testing.T) {
})
}
+func TestDatabricksWithURI(t *testing.T) {
+ withQuirksURI(t, func(q *DatabricksQuirks) {
+ suite.Run(t, &DatabricksTests{Quirks: q})
+ })
+}
+
Review Comment:
I don't think we really need to run all tests again...just check that we can
connect and execute a trivial query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
