friendlymatthew commented on PR #8937: URL: https://github.com/apache/arrow-rs/pull/8937#issuecomment-3647752009
> If we are going to do this, I think we should clearly document somewhere what "equal" means for `DataType::Union` and `UnionArray` and make sure the crate is consistent with this definition I agree that we should document what "equal" means for `DataType::Union` and `UnionArray`. But isn't `DataType::equals_datatype` already the authoritative definition of equality for `DataType::Union`? The specific match arm for unions is here: https://github.com/apache/arrow-rs/blob/08dcc0b8c552e81d612b53bc0ab2a0007bfe20a1/arrow-schema/src/datatype.rs#L676-L688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
