dqkqd commented on code in PR #8735:
URL: https://github.com/apache/arrow-rs/pull/8735#discussion_r2615748022
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -12090,6 +12107,206 @@ mod tests {
assert_eq!(run_array.run_ends().values(), &[3i64, 6i64, 9i64]);
}
+ fn int32_list_values() -> Vec<Option<Vec<Option<i32>>>> {
+ vec![
+ Some(vec![Some(1), Some(2), Some(3)]),
+ Some(vec![Some(4), Some(5), Some(6)]),
+ None,
+ Some(vec![Some(7), Some(8), Some(9)]),
+ Some(vec![None, Some(10)]),
+ ]
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list() {
+ let list_view = ListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+ let expected_list = ListArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_to_list_view() {
+ let list = ListArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type = DataType::ListView(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list.data_type(), &target_type));
+ let cast_result = cast(&list, &target_type).unwrap();
+
+ let got_list_view = cast_result
+ .as_any()
+ .downcast_ref::<ListViewArray>()
+ .unwrap();
+ let expected_list_view =
+ ListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got_list_view, &expected_list_view);
+ }
+
+ #[test]
+ fn test_cast_large_list_view_to_large_list() {
+ let list_view =
+ LargeListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type = DataType::LargeList(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list = cast_result
+ .as_any()
+ .downcast_ref::<LargeListArray>()
+ .unwrap();
+
+ let expected_list =
+ LargeListArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_large_list_to_large_list_view() {
+ let list = LargeListArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type =
+ DataType::LargeListView(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list.data_type(), &target_type));
+ let cast_result = cast(&list, &target_type).unwrap();
+
+ let got_list_view = cast_result
+ .as_any()
+ .downcast_ref::<LargeListViewArray>()
+ .unwrap();
+ let expected_list_view =
+ LargeListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got_list_view, &expected_list_view);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list_out_of_order() {
+ let list_view = ListViewArray::new(
+ Arc::new(Field::new("item", DataType::Int32, true)),
+ ScalarBuffer::from(vec![0, 6, 3]),
+ ScalarBuffer::from(vec![3, 3, 3]),
+ Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8, 9])),
+ None,
+ );
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+ let expected_list = ListArray::from_iter_primitive::<Int32Type, _,
_>(vec![
+ Some(vec![Some(1), Some(2), Some(3)]),
+ Some(vec![Some(7), Some(8), Some(9)]),
+ Some(vec![Some(4), Some(5), Some(6)]),
+ ]);
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list_overlapping() {
+ let list_view = ListViewArray::new(
+ Arc::new(Field::new("item", DataType::Int32, true)),
+ ScalarBuffer::from(vec![0, 0]),
+ ScalarBuffer::from(vec![1, 2]),
+ Arc::new(Int32Array::from(vec![1, 2])),
+ None,
+ );
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+ let expected_list = ListArray::from_iter_primitive::<Int32Type, _,
_>(vec![
+ Some(vec![Some(1)]),
+ Some(vec![Some(1), Some(2)]),
+ ]);
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list_empty() {
+ let values: Vec<Option<Vec<Option<i32>>>> = vec![];
+ let list_view = ListViewArray::from_iter_primitive::<Int32Type, _,
_>(values.clone());
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+ let expected_list = ListArray::from_iter_primitive::<Int32Type, _,
_>(values);
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list_different_inner_type() {
+ let values = int32_list_values();
+ let list_view = ListViewArray::from_iter_primitive::<Int32Type, _,
_>(values.clone());
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int64, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+
+ let expected_list =
+ ListArray::from_iter_primitive::<Int64Type, _,
_>(values.into_iter().map(|list| {
+ list.map(|list| {
+ list.into_iter()
+ .map(|v| v.map(|v| v as i64))
+ .collect::<Vec<_>>()
+ })
+ }));
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_list_out_of_order_with_nulls() {
+ let list_view = ListViewArray::new(
+ Arc::new(Field::new("item", DataType::Int32, true)),
+ ScalarBuffer::from(vec![0, 6, 3]),
+ ScalarBuffer::from(vec![3, 3, 3]),
+ Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8, 9])),
+ Some(NullBuffer::from(vec![false, true, false])),
+ );
+ let target_type = DataType::List(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got_list =
cast_result.as_any().downcast_ref::<ListArray>().unwrap();
+ let expected_list = ListArray::new(
+ Arc::new(Field::new("item", DataType::Int32, true)),
+ OffsetBuffer::from_lengths([3, 3, 3]),
+ Arc::new(Int32Array::from(vec![1, 2, 3, 7, 8, 9, 4, 5, 6])),
+ Some(NullBuffer::from(vec![false, true, false])),
+ );
+ assert_eq!(got_list, &expected_list);
+ }
+
+ #[test]
+ fn test_cast_list_view_to_large_list_view() {
+ let list_view = ListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type =
+ DataType::LargeListView(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got = cast_result
+ .as_any()
+ .downcast_ref::<LargeListViewArray>()
+ .unwrap();
+
+ let expected =
+ LargeListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got, &expected);
+ }
+
+ #[test]
+ fn test_cast_large_list_view_to_list_view() {
+ let list_view =
+ LargeListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ let target_type = DataType::ListView(Arc::new(Field::new("item",
DataType::Int32, true)));
+ assert!(can_cast_types(list_view.data_type(), &target_type));
+ let cast_result = cast(&list_view, &target_type).unwrap();
+ let got = cast_result
+ .as_any()
+ .downcast_ref::<ListViewArray>()
+ .unwrap();
+
+ let expected = ListViewArray::from_iter_primitive::<Int32Type, _,
_>(int32_list_values());
+ assert_eq!(got, &expected);
+ assert_eq!(got, &expected);
Review Comment:
just a nit here.
```suggestion
assert_eq!(got, &expected);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
