Dandandan commented on code in PR #8951:
URL: https://github.com/apache/arrow-rs/pull/8951#discussion_r2616173620
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -193,6 +193,85 @@ impl NullBufferBuilder {
}
}
+ /// Extends this builder with validity values.
+ ///
+ ///
+ /// # Example
+ /// ```
+ /// # use arrow_buffer::NullBufferBuilder;
+ /// let mut builder = NullBufferBuilder::new(8);
+ /// let validities = [true, false, true, true];
+ /// builder.extend(validities.iter().copied());
+ /// assert_eq!(builder.len(), 4);
+ /// ```
+ pub fn extend<I: Iterator<Item = bool>>(&mut self, iter: I) {
+ let (lower, upper) = iter.size_hint();
Review Comment:
Sounds good, I'll do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
