faysou commented on code in PR #576: URL: https://github.com/apache/arrow-rs-object-store/pull/576#discussion_r2616307994
########## Cargo.toml: ########## @@ -71,14 +72,20 @@ wasm-bindgen-futures = "0.4.18" [features] default = ["fs"] -cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest", "reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util", "form_urlencoded", "serde_urlencoded"] -azure = ["cloud", "httparse"] fs = ["walkdir"] -gcp = ["cloud", "rustls-pki-types"] -aws = ["cloud", "md-5"] -http = ["cloud"] +cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest", "reqwest/stream", "chrono/serde", "base64", "rand", "http-body-util", "form_urlencoded", "serde_urlencoded"] +azure = ["cloud", "httparse", "ring"] +gcp = ["cloud", "rustls-pki-types", "ring"] +aws = ["cloud", "md-5", "ring"] +http = ["cloud", "ring"] +azure-aws-lc = ["cloud", "httparse", "aws-lc"] +gcp-aws-lc = ["cloud", "rustls-pki-types", "aws-lc"] +aws-aws-lc = ["cloud", "md-5", "aws-lc"] +http-aws-lc = ["cloud", "aws-lc"] Review Comment: From my past experience using native tls required openssl, then I'm not an expert on this. But using rustls no provider allows more control on which rustls crypto provider is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
