mapleFU commented on code in PR #8989:
URL: https://github.com/apache/arrow-rs/pull/8989#discussion_r2617128617
##########
arrow-array/src/builder/fixed_size_binary_builder.rs:
##########
@@ -101,6 +102,19 @@ impl FixedSizeBinaryBuilder {
self.null_buffer_builder.append_n_nulls(n);
}
+ /// Appends all elements in array into the builder.
+ pub fn append_array(&mut self, array: &FixedSizeBinaryArray) -> Result<(),
ArrowError> {
Review Comment:
I'm afraid this is not efficient enough. Why not copying value and the null
buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
