ennuite commented on PR #933: URL: https://github.com/apache/arrow-java/pull/933#issuecomment-3651796107
I'm not sure if I should further refactor the logic on `ArrowFlightConnection.close()` The changes so far are mostly to address the bug at #932 so I didn't touch the old logic a lot. However, the way things are is that if an Exception gets thrown for example in `AutoCloseables.close(clientHandler);` we immediately throw the Exception and don't attempt to clean the rest of the resources. I wonder if it would make more sense to use a logic similar to `AutoCloseables.close()` for every resource, and proceed with the cleanup until the end, and then throwing all the Exceptions generated. The class `ArrowFlightJdbcVectorSchemaRootResultSet` uses this approach I'm mentioning for its close method. Let me know if you want me to do that refactoring in this or another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
