IIFE commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2617402226
##########
c/cmake_modules/DefineOptions.cmake:
##########
@@ -232,6 +232,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
define_option(ADBC_DRIVER_BIGQUERY "Build the BigQuery driver" OFF)
define_option(ADBC_INTEGRATION_DUCKDB "Build the test suite for DuckDB" OFF)
+
+ define_option(ADBC_BUILD_VCPKG "Build on Windows using vcpkg for
dependencies and Visual Studio generator." OFF)
Review Comment:
Need to ensure that runtime dependencies are copied during install. Using
Win32 condition causes other non vcpkg builds on windows to fail, so decided to
add this specific option for the vcpkg build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
