prtkgaur commented on PR #48345:
URL: https://github.com/apache/arrow/pull/48345#issuecomment-3658300715
> Talked offline and wanted to capture notes on high-level changes:
>
> 1. For headers, lets try to reduce duplication with values already in the
parquet header.
> 2. For remaining items in headers, lets try to be parsimonious with values
(i.e. 4 bytes is probably overkill for enums)
> 3. Naming convention on files is off (use snake_case).
> 4. Given description of ALP, we probably want a top level encoding enum
value for the 2 different modes of ALP.
Thanks for the feedback @emkornfield. We have addressed
1) Reduce duplication of fields between page header and alp header
2) Other fields have been updated to use 1 byte. Header is now just 8 bytes
compared to 40 bytes earlier.
3) Naming of files has been updated.
4) We do have the top level enums describing the mode and layout structure.
enum class AlpBitPackLayout { kNormal }; and enum class AlpMode { kAlp };
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
