alinaliBQ commented on code in PR #48313:
URL: https://github.com/apache/arrow/pull/48313#discussion_r2624336559
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -186,6 +186,7 @@ if(WIN32)
#
# ARROW-2986: Without /EHsc we get C4530 warning
set(CXX_COMMON_FLAGS "/W3 /EHsc")
+ string(APPEND CMAKE_CXX_FLAGS " /EHsc")
Review Comment:
Sure, I have pushed the changes for `cpp/CMakeLists.txt` and removed the new
line I added
##########
.github/workflows/cpp_extra.yml:
##########
@@ -330,12 +332,22 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+ odbc:
+ needs: check-labels
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ name: C++ ODBC
+ uses: ./.github/workflows/cpp_odbc.yml
+
report-extra-cpp:
if: github.event_name == 'schedule' && always()
needs:
- docker
- jni-linux
- jni-macos
- msvc-arm64
+ - odbc
Review Comment:
all good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
