thisisnic commented on code in PR #48014:
URL: https://github.com/apache/arrow/pull/48014#discussion_r2627675390
##########
ci/scripts/r_test.sh:
##########
@@ -101,7 +101,7 @@ SCRIPT="as_cran <-
!identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
build_args <- '--no-build-vignettes'
}
- if (!as_cran && requireNamespace('reticulate', quietly = TRUE) &&
reticulate::py_module_available('pyarrow')) {
+ if (!as_cran && (requireNamespace('reticulate', quietly = TRUE)) &&
reticulate::py_module_available('pyarrow')) {
Review Comment:
Hmm...they don't - I tried it locally before/after, and whatever was
invoking a Python module install must have succeeded when I ran the "before"
version, and so when I ran it again "after", I conflated the change in the
environment (and thus no console output) with the code change working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
