kou commented on code in PR #48414:
URL: https://github.com/apache/arrow/pull/48414#discussion_r2633209732
##########
matlab/tools/cmake/BuildMatlabArrowInterface.cmake:
##########
@@ -131,7 +131,7 @@ libmexclass_client_add_proxy_library(
LINK_LIBRARIES arrow_shared
)
# Use C++17
Review Comment:
Could you update this too?
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -1181,7 +1181,7 @@ endif()
foreach(LIB_TARGET ${ARROW_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_EXPORTING)
# C++17 is required to compile against Arrow C++ headers and libraries
Review Comment:
Could you update this "C++17" too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
