mhilton commented on code in PR #9016:
URL: https://github.com/apache/arrow-rs/pull/9016#discussion_r2634619835
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -884,12 +895,15 @@ impl<T: ByteViewType + ?Sized> Array for
GenericByteViewArray<T> {
}
fn shrink_to_fit(&mut self) {
+ /*
self.views.shrink_to_fit();
self.buffers.iter_mut().for_each(|b| b.shrink_to_fit());
self.buffers.shrink_to_fit();
if let Some(nulls) = &mut self.nulls {
nulls.shrink_to_fit();
}
+ */
+ todo!()
Review Comment:
Did you mean to leave this todo here? It seems to me that it might be
important to finish this part. If it isn't necessary could you add a comment
explaining why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
