alinaliBQ commented on code in PR #48577:
URL: https://github.com/apache/arrow/pull/48577#discussion_r2636507269
##########
ci/scripts/cpp_build.sh:
##########
@@ -259,7 +259,7 @@ else
-DCMAKE_BUILD_TYPE=${ARROW_BUILD_TYPE:-debug} \
-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE:-OFF} \
-DCMAKE_C_FLAGS="${CFLAGS:-}" \
- -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
+ -DCMAKE_CXX_FLAGS="${CXXFLAGS:-} -I${ODBC_INCLUDE_DIR:-}
-L${ODBC_LIB_DIR:-}" \
-DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \
Review Comment:
I am open to suggestions for other locations for `-I` and `-L` 🙂
##########
cpp/CMakePresets.json:
##########
@@ -314,6 +314,17 @@
"displayName": "Debug build with tests and Flight SQL",
"cacheVariables": {}
},
Review Comment:
ODBC can be built on Windows and macOS Intel/ARM but it is not available on
Linux yet (we will add Linux support later), let me know if this change should
be removed until Linux is also supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
