kou commented on code in PR #48489:
URL: https://github.com/apache/arrow/pull/48489#discussion_r2636534405
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -7091,6 +7094,215 @@ garrow_extract_regex_options_new(void)
return GARROW_EXTRACT_REGEX_OPTIONS(options);
}
+enum {
+ PROP_LIST_SLICE_OPTIONS_START = 1,
+ PROP_LIST_SLICE_OPTIONS_STOP,
+ PROP_LIST_SLICE_OPTIONS_STEP,
+ PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST,
+};
+
+G_DEFINE_TYPE(GArrowListSliceOptions,
+ garrow_list_slice_options,
+ GARROW_TYPE_FUNCTION_OPTIONS)
+
+static void
+garrow_list_slice_options_set_property(GObject *object,
+ guint prop_id,
+ const GValue *value,
+ GParamSpec *pspec)
+{
+ auto options =
garrow_list_slice_options_get_raw(GARROW_LIST_SLICE_OPTIONS(object));
+
+ switch (prop_id) {
+ case PROP_LIST_SLICE_OPTIONS_START:
+ options->start = g_value_get_int64(value);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STOP:
+ {
+ gint64 stop_value = g_value_get_int64(value);
+ if (stop_value == -1) {
+ options->stop = std::nullopt;
+ } else {
+ options->stop = stop_value;
+ }
+ }
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STEP:
+ options->step = g_value_get_int64(value);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST:
+ {
+ auto return_fixed_size_list_value =
+
static_cast<GArrowListSliceReturnFixedSizeList>(g_value_get_enum(value));
+ switch (return_fixed_size_list_value) {
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_AUTO:
+ options->return_fixed_size_list = std::nullopt;
+ break;
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_FALSE:
+ options->return_fixed_size_list = false;
+ break;
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_TRUE:
+ options->return_fixed_size_list = true;
+ break;
+ default:
+ options->return_fixed_size_list = std::nullopt;
+ break;
+ }
+ }
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
+ break;
+ }
+}
+
+static void
+garrow_list_slice_options_get_property(GObject *object,
+ guint prop_id,
+ GValue *value,
+ GParamSpec *pspec)
+{
+ auto options =
garrow_list_slice_options_get_raw(GARROW_LIST_SLICE_OPTIONS(object));
+
+ switch (prop_id) {
+ case PROP_LIST_SLICE_OPTIONS_START:
+ g_value_set_int64(value, options->start);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STOP:
+ if (options->stop.has_value()) {
+ g_value_set_int64(value, options->stop.value());
+ } else {
+ g_value_set_int64(value, -1); // Sentinel value for "not set"
Review Comment:
Could you add `#define GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED -1` or
something to `compute.h` and use it here and others?
gobject-introspection gem defines it in Ruby automatically. So we can use it
in our tests.
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -7091,6 +7094,215 @@ garrow_extract_regex_options_new(void)
return GARROW_EXTRACT_REGEX_OPTIONS(options);
}
+enum {
+ PROP_LIST_SLICE_OPTIONS_START = 1,
+ PROP_LIST_SLICE_OPTIONS_STOP,
+ PROP_LIST_SLICE_OPTIONS_STEP,
+ PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST,
+};
+
+G_DEFINE_TYPE(GArrowListSliceOptions,
+ garrow_list_slice_options,
+ GARROW_TYPE_FUNCTION_OPTIONS)
+
+static void
+garrow_list_slice_options_set_property(GObject *object,
+ guint prop_id,
+ const GValue *value,
+ GParamSpec *pspec)
+{
+ auto options =
garrow_list_slice_options_get_raw(GARROW_LIST_SLICE_OPTIONS(object));
+
+ switch (prop_id) {
+ case PROP_LIST_SLICE_OPTIONS_START:
+ options->start = g_value_get_int64(value);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STOP:
+ {
+ gint64 stop_value = g_value_get_int64(value);
+ if (stop_value == -1) {
+ options->stop = std::nullopt;
+ } else {
+ options->stop = stop_value;
+ }
+ }
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STEP:
+ options->step = g_value_get_int64(value);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST:
+ {
+ auto return_fixed_size_list_value =
+
static_cast<GArrowListSliceReturnFixedSizeList>(g_value_get_enum(value));
+ switch (return_fixed_size_list_value) {
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_AUTO:
+ options->return_fixed_size_list = std::nullopt;
+ break;
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_FALSE:
+ options->return_fixed_size_list = false;
+ break;
+ case GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_TRUE:
+ options->return_fixed_size_list = true;
+ break;
+ default:
+ options->return_fixed_size_list = std::nullopt;
+ break;
+ }
+ }
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
+ break;
+ }
+}
+
+static void
+garrow_list_slice_options_get_property(GObject *object,
+ guint prop_id,
+ GValue *value,
+ GParamSpec *pspec)
+{
+ auto options =
garrow_list_slice_options_get_raw(GARROW_LIST_SLICE_OPTIONS(object));
+
+ switch (prop_id) {
+ case PROP_LIST_SLICE_OPTIONS_START:
+ g_value_set_int64(value, options->start);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STOP:
+ if (options->stop.has_value()) {
+ g_value_set_int64(value, options->stop.value());
+ } else {
+ g_value_set_int64(value, -1); // Sentinel value for "not set"
+ }
+ break;
+ case PROP_LIST_SLICE_OPTIONS_STEP:
+ g_value_set_int64(value, options->step);
+ break;
+ case PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST:
+ if (options->return_fixed_size_list.has_value()) {
+ if (options->return_fixed_size_list.value()) {
+ g_value_set_enum(value, GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_TRUE);
+ } else {
+ g_value_set_enum(value,
GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_FALSE);
+ }
+ } else {
+ // When not set (nullopt), return AUTO (default)
+ g_value_set_enum(value, GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_AUTO);
+ }
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
+ break;
+ }
+}
+
+static void
+garrow_list_slice_options_init(GArrowListSliceOptions *object)
+{
+ auto priv = GARROW_FUNCTION_OPTIONS_GET_PRIVATE(object);
+ priv->options = static_cast<arrow::compute::FunctionOptions *>(
+ new arrow::compute::ListSliceOptions());
+}
+
+static void
+garrow_list_slice_options_class_init(GArrowListSliceOptionsClass *klass)
+{
+ auto gobject_class = G_OBJECT_CLASS(klass);
+
+ gobject_class->set_property = garrow_list_slice_options_set_property;
+ gobject_class->get_property = garrow_list_slice_options_get_property;
+
+ arrow::compute::ListSliceOptions options;
+
+ GParamSpec *spec;
+ /**
+ * GArrowListSliceOptions:start:
+ *
+ * The start of list slicing.
+ *
+ * Since: 23.0.0
+ */
+ spec = g_param_spec_int64("start",
+ "Start",
+ "The start of list slicing",
+ G_MININT64,
+ G_MAXINT64,
+ options.start,
+ static_cast<GParamFlags>(G_PARAM_READWRITE));
+ g_object_class_install_property(gobject_class,
PROP_LIST_SLICE_OPTIONS_START, spec);
+
+ /**
+ * GArrowListSliceOptions:stop:
+ *
+ * Optional stop of list slicing. If not set (value is -1), then slice to
end.
+ *
+ * Since: 23.0.0
+ */
+ spec = g_param_spec_int64(
+ "stop",
+ "Stop",
+ "Optional stop of list slicing. If not set (value is -1), then slice to
end",
+ -1, // Use -1 as sentinel for "not set"
+ G_MAXINT64,
+ -1, // Default to -1 (not set)
+ static_cast<GParamFlags>(G_PARAM_READWRITE));
+ g_object_class_install_property(gobject_class, PROP_LIST_SLICE_OPTIONS_STOP,
spec);
+
+ /**
+ * GArrowListSliceOptions:step:
+ *
+ * Slicing step.
+ *
+ * Since: 23.0.0
+ */
+ spec = g_param_spec_int64("step",
+ "Step",
+ "Slicing step",
+ G_MININT64,
+ G_MAXINT64,
+ options.step,
+ static_cast<GParamFlags>(G_PARAM_READWRITE));
+ g_object_class_install_property(gobject_class, PROP_LIST_SLICE_OPTIONS_STEP,
spec);
+
+ /**
+ * GArrowListSliceOptions:return-fixed-size-list:
+ *
+ * Whether to return a FixedSizeListArray. If
+ * #GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_TRUE and stop is after a list
element's
+ * length, nulls will be appended to create the requested slice size. If
+ * #GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_AUTO (default), will return
whatever type
+ * it got in.
+ *
+ * Since: 23.0.0
+ */
+ spec = g_param_spec_enum(
+ "return-fixed-size-list",
+ "Return fixed size list",
+ "Whether to return a FixedSizeListArray. If TRUE and stop is after a list
element's "
+ "length, nulls will be appended to create the requested slice size. If
AUTO "
+ "(default), will return whatever type it got in",
+ GARROW_TYPE_LIST_SLICE_RETURN_FIXED_SIZE_LIST,
+ GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_AUTO,
+ static_cast<GParamFlags>(G_PARAM_READWRITE));
+ g_object_class_install_property(gobject_class,
+
PROP_LIST_SLICE_OPTIONS_RETURN_FIXED_SIZE_LIST,
+ spec);
+}
+
+/**
+ * garrow_list_slice_options_new:
+ *
+ * Returns: A newly created #GArrowListSliceOptions.
+ *
+ * Since: 23.0.0
+ */
+GArrowListSliceOptions *
+garrow_list_slice_options_new(void)
+{
+ auto options = g_object_new(GARROW_TYPE_LIST_SLICE_OPTIONS, NULL);
Review Comment:
Could you use `nullptr` instead of `NULL` because C++ prefers `nullptr`?
```suggestion
auto options = g_object_new(GARROW_TYPE_LIST_SLICE_OPTIONS, nullptr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
