scovich commented on code in PR #9012:
URL: https://github.com/apache/arrow-rs/pull/9012#discussion_r2637464925
##########
parquet-variant/src/path.rs:
##########
@@ -112,11 +114,7 @@ impl<'a> From<Vec<VariantPathElement<'a>>> for
VariantPath<'a> {
/// Create from &str with support for dot notation
impl<'a> From<&'a str> for VariantPath<'a> {
fn from(path: &'a str) -> Self {
- if path.is_empty() {
- VariantPath::new(vec![])
- } else {
- VariantPath::new(path.split('.').map(Into::into).collect())
- }
+ VariantPath::new(path.split(".").flat_map(parse_path).collect())
Review Comment:
AFAIK, variant is still experimental, so breaking changes are ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
