IIFE commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2640204899
##########
c/cmake_modules/BuildUtils.cmake:
##########
@@ -289,6 +300,18 @@ function(ADD_ARROW_LIB LIB_NAME)
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
INCLUDES
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+
+ # If we're building on Windows using vcpkg, ensure the runtime
dependencies of binaries are copied to the install folder.
+ if(ADBC_BUILD_VCPKG)
Review Comment:
Hmm had a quick look but can't see a better way at the moment. The problem
is that runtime dependencies copying doesn't work for other builds like
python/conda etc. Maybe we can spend more time investigating in a separate PR
if that's OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
