lidavidm commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2642054872
##########
c/driver/sqlite/statement_reader.c:
##########
@@ -451,8 +451,16 @@ AdbcStatusCode InternalAdbcSqliteBinderBindNext(struct
AdbcSqliteBinder* binder,
}
case NANOARROW_TYPE_TIMESTAMP: {
struct ArrowSchemaView bind_schema_view;
+#ifdef _MSC_VER
+#pragma warning(push)
+#pragma warning(disable : 4244) // RAISE_NA returns ArrowErrorCode, but this
function
+ // returns AdbcStatusCode
+#endif
Review Comment:
```suggestion
// TODO(https://github.com/apache/arrow-adbc/issues/1675)
#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4244) // RAISE_NA returns ArrowErrorCode, but
this function
// returns AdbcStatusCode
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
