alamb opened a new pull request, #9039: URL: https://github.com/apache/arrow-rs/pull/9039
# Which issue does this PR close? - Follow on to https://github.com/apache/arrow-rs/pull/9020 # Rationale for this change @Jefffrey suggested renaming these fields would help make it even more clear that the offset and lengths in `BooleanBuffer` are in terms of bits (not bytes) # What changes are included in this PR? Update field names and improve some more comments # Are these changes tested? # Are there any user-facing changes? No, this is internal field name and documentation changes only I did consider deprecating `BooleanBuffer::len` and renaming it to `BooleanBuffer::bit_len` and similarly for offset, but that seems overly aggressive for downstream consumers (they have to make changes for no obvious benefit 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
