thisisnic commented on code in PR #48634: URL: https://github.com/apache/arrow/pull/48634#discussion_r2645410798
########## r/src/altrep.cpp: ########## @@ -197,6 +194,7 @@ struct AltrepVectorPrimitive : public AltrepVectorBase<AltrepVectorPrimitive<sex // singleton altrep class description static R_altrep_class_t class_t; + static const char* class_name; Review Comment: We need this to extract the class name a different way - before we were doing it via code which used `ATTRIB` - so having it declared here means that we can set it when we initialise the class (where we do `AltrepClass::class_name = name;`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
