HyukjinKwon commented on code in PR #48661:
URL: https://github.com/apache/arrow/pull/48661#discussion_r2647527214


##########
r/tests/testthat/test-dplyr-arrange.R:
##########
@@ -245,3 +245,11 @@ test_that("Can use across() within arrange()", {
     example_data
   )
 })
+
+test_that("arrange() with aggregation expressions errors", {
+  tab <- arrow_table(tbl)
+  expect_warning(

Review Comment:
   Has to catch warning instead per:
   
   ```
   ── Warning ('test-dplyr-filter.R:496:3'): filter() with aggregation 
expressions errors ──
   In int < mean(int): 
   i Expression not supported in filter() in Arrow
   > Pulling data into R
   Backtrace:
        ▆
     1. ├─testthat::expect_error(filter(tab, int < mean(int)), "not supported 
in filter") at test-dplyr-filter.R:496:3
     2. │ └─testthat:::expect_condition_matching_(...)
     3. │   └─testthat:::quasi_capture(...)
     4. │     ├─testthat (local) .capture(...)
     5. │     │ └─base::withCallingHandlers(...)
     6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
     7. ├─dplyr::filter(tab, int < mean(int))
     8. └─arrow:::filter.ArrowTabular(tab, int < mean(int))
     9.   └─arrow:::try_arrow_dplyr(...)
    10.     └─base::tryCatch(...)
    11.       └─base (local) tryCatchList(expr, classes, parentenv, handlers)
    12.         └─base (local) tryCatchOne(expr, names, parentenv, 
handlers[[1L]])
    13.           └─value[[3L]](cond)
    14.             └─arrow:::abandon_ship(e, parent)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to