Jefffrey commented on code in PR #9000:
URL: https://github.com/apache/arrow-rs/pull/9000#discussion_r2647798719
##########
arrow-row/src/lib.rs:
##########
@@ -1930,6 +1927,15 @@ unsafe fn decode_column(
let child_array =
unsafe { converter.convert_raw(&mut child_data,
validate_utf8) }?;
+ // advance row slices by the bytes consumed
+ for ((row_idx, original_bytes), remaining_bytes) in
+ field_rows.iter().zip(child_data)
+ {
+ let consumed_length =
+ 1 + original_bytes.len() -
remaining_bytes.len();
Review Comment:
```suggestion
let consumed_length = 1 + original_bytes.len() -
remaining_bytes.len();
```
##########
arrow-row/src/lib.rs:
##########
@@ -1930,6 +1927,15 @@ unsafe fn decode_column(
let child_array =
unsafe { converter.convert_raw(&mut child_data,
validate_utf8) }?;
+ // advance row slices by the bytes consumed
+ for ((row_idx, original_bytes), remaining_bytes) in
+ field_rows.iter().zip(child_data)
+ {
+ let consumed_length =
+ 1 + original_bytes.len() -
remaining_bytes.len();
Review Comment:
```suggestion
let consumed_length = 1 + original_bytes.len() -
remaining_bytes.len();
```
fmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
