alamb commented on PR #9022:
URL: https://github.com/apache/arrow-rs/pull/9022#issuecomment-3693942423
Sadly the as_chunks implementation needs a newer MSRV:
```diff
+ } else {
+ let (left_slices, left_remainder) = left.as_chunks::<8>();
+ let (right_slices, right_remainder) = right.as_chunks::<8>();
+ debug_assert_eq!(left_slices.len(), right_slices.len());
+ debug_assert_eq!(left_remainder.len(), right_remainder.len());
+ let mut mutable_result =
+ MutableBuffer::with_capacity(left_slices.len() * 8 +
left_remainder.len());
+ mutable_result.extend_from_iter(
+ left_slices
+ .iter()
+ .zip(right_slices.iter())
+ .map(|(l, r)| op(u64::from_le_bytes(*l),
u64::from_le_bytes(*r))),
+ );
+ if !left_remainder.is_empty() {
+ let rem = op(
+ u64::from_le_bytes({
+ let mut bytes = [0u8; 8];
+
bytes[..left_remainder.len()].copy_from_slice(left_remainder);
+ bytes
+ }),
+ u64::from_le_bytes({
+ let mut bytes = [0u8; 8];
+
bytes[..right_remainder.len()].copy_from_slice(right_remainder);
+ bytes
+ }),
+ );
+
mutable_result.extend_from_slice(&rem.to_le_bytes()[..left_remainder.len()]);
+ }
+ BooleanBuffer {
+ buffer: Buffer::from(mutable_result),
+ offset: 0,
+ len: len_in_bits,
+ }
}
```
error: current MSRV (Minimum Supported Rust Version) is `1.85.0` but this
item is stable since `1.88.0`
--> arrow-buffer/src/buffer/boolean.rs:370:54
|
370 | let (left_slices, left_remainder) = left.as_chunks::<8>();
| ^^^^^^^^^^^^^^^^
|
= note: you may want to conditionally increase the MSRV considered by
Clippy using the `clippy::msrv` attribute
= help: for further information visit
https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#incompatible_msrv
= note: `-D clippy::incompatible-msrv` implied by `-D warnings`
= help: to override `-D warnings` add
`#[allow(clippy::incompatible_msrv)]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
