jonkeane commented on code in PR #48653:
URL: https://github.com/apache/arrow/pull/48653#discussion_r2649201757
##########
r/tests/testthat/test-compute-arith.R:
##########
@@ -71,8 +71,6 @@ test_that("Division", {
expect_equal(a / 2 / 2, Array$create(c(1:4 / 2 / 2, NA_real_)))
expect_equal(a %/% 2L %/% 2L, Array$create(c(0L, 0L, 0L, 1L, NA_integer_)))
expect_equal(a / 0, Array$create(c(Inf, Inf, Inf, Inf, NA_real_)))
- # TODO add tests for integer division %/% by 0
- # see https://issues.apache.org/jira/browse/ARROW-14297
Review Comment:
I wouldn't mind also having a test here as well as the dplyr tests. Or
alternatively: maybe we mention that the `%/%` tests are in the dplyr math file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
