lidavidm commented on code in PR #48050:
URL: https://github.com/apache/arrow/pull/48050#discussion_r2652094801
##########
cpp/src/arrow/flight/sql/column_metadata.cc:
##########
@@ -58,8 +58,10 @@ const char* ColumnMetadata::kIsSearchable =
"ARROW:FLIGHT:SQL:IS_SEARCHABLE";
const char* ColumnMetadata::kRemarks = "ARROW:FLIGHT:SQL:REMARKS";
ColumnMetadata::ColumnMetadata(
- std::shared_ptr<const arrow::KeyValueMetadata> metadata_map)
- : metadata_map_(std::move(metadata_map)) {}
+ std::shared_ptr<const arrow::KeyValueMetadata> metadata_map) {
+ metadata_map_ = std::move(metadata_map ? metadata_map
Review Comment:
ack, I was questioning that line and should've checked the CI...let's revert
for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
