HyukjinKwon opened a new pull request, #48687: URL: https://github.com/apache/arrow/pull/48687
### Rationale for this change Fixes compilation error on macOS: `-Wpessimizing-move` warning. `std::move()` on a ternary expression prevents copy elision. `shared_ptr` assignment already handles moves automatically, so `std::move` is unnecessary and hurts optimization. ### What changes are included in this PR? Removed `std::move()` from ternary expression in `ColumnMetadata` constructor (`cpp/src/arrow/flight/sql/column_metadata.cc:62`). Behavior unchanged - still ensures `metadata_map_` is never null. ### Are these changes tested? Yes. Existing tests cover `ColumnMetadata` functionality. No behavioral changes, so tests continue to pass. ### Are there any user-facing changes? No. Compilation fix only. Behavior identical, may have slight performance improvement from better compiler optimizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
