jbonofre commented on code in PR #941:
URL: https://github.com/apache/arrow-java/pull/941#discussion_r2652360889
##########
vector/src/main/java/org/apache/arrow/vector/TimeStampMicroTZVector.java:
##########
@@ -155,12 +155,13 @@ public void set(int index, NullableTimeStampMicroTZHolder
holder)
throws IllegalArgumentException {
if (holder.isSet < 0) {
throw new IllegalArgumentException();
- } else if (!this.timeZone.equals(holder.timezone)) {
- throw new IllegalArgumentException(
- String.format(
- "holder.timezone: %s not equal to vector timezone: %s",
- holder.timezone, this.timeZone));
} else if (holder.isSet > 0) {
+ if (!this.timeZone.equals(holder.timezone)) {
Review Comment:
This looks better to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]