manishkr commented on code in PR #9036:
URL: https://github.com/apache/arrow-rs/pull/9036#discussion_r2652411579
##########
arrow-buffer/src/buffer/run.rs:
##########
@@ -189,6 +189,16 @@ where
&self.run_ends
}
+ /// Similar to [`values`] but accounts for logical slicing, returning only
the values
+ /// that are part of the logical slice of this buffer.
+ ///
+ /// [`values`]: Self::values
+ pub fn values_slice(&self) -> &[E] {
Review Comment:
Thanks. Added warning but not sure logical run ends API(`logical_run_ends`)
is needed or not, but added it. Please feel free to suggest to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
