HyukjinKwon opened a new pull request, #48697: URL: https://github.com/apache/arrow/pull/48697
### Rationale for this change 968e6ea488c added incorrect bitmask examples for `SQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELS`. https://github.com/apache/arrow/blob/968e6ea488c939c0e1f2bfe339a5a9ed1aed603e/format/FlightSql.proto#L588-L590 The bitmask incorrectly mapped bit 2 (value 4 = `\b100`) to `SQL_TRANSACTION_REPEATABLE_READ` instead of `SQL_TRANSACTION_READ_COMMITTED`, and omitted `SQL_TRANSACTION_READ_COMMITTED` entirely. According to the enum definition: https://github.com/apache/arrow/blob/968e6ea488c939c0e1f2bfe339a5a9ed1aed603e/format/FlightSql.proto#L820-L826 The correct bit-to-enum mapping should be: - Bit 0 (value 1) = `SQL_TRANSACTION_NONE` (enum value 0) - Bit 1 (value 2) = `SQL_TRANSACTION_READ_UNCOMMITTED` (enum value 1) - Bit 2 (value 4) = `SQL_TRANSACTION_READ_COMMITTED` (enum value 2) - Bit 3 (value 8) = `SQL_TRANSACTION_REPEATABLE_READ` (enum value 3) - Bit 4 (value 16) = `SQL_TRANSACTION_SERIALIZABLE` (enum value 4) ### What changes are included in this PR? - Added `SQL_TRANSACTION_READ_COMMITTED` properly in the comments. - `SQL positioned commands` (presumably copied and pasted from other places) -> `SQL transaction isolation levels` for `SQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELS` - `SQL positioned commands` (presumably copied and pasted from other places) -> `SQL transaction UNIONs` for `SQL_SUPPORTED_UNIONS` - Several typo fixes. ### Are these changes tested? No, I did not test as they are comment-only. ### Are there any user-facing changes? No, dev-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
