kou commented on code in PR #48530:
URL: https://github.com/apache/arrow/pull/48530#discussion_r2655067462
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -7091,6 +7094,134 @@ garrow_extract_regex_options_new(void)
return GARROW_EXTRACT_REGEX_OPTIONS(options);
}
+enum {
+ PROP_TRIM_OPTIONS_CHARACTERS = 1,
+};
+
+typedef struct _GArrowTrimOptionsPrivate GArrowTrimOptionsPrivate;
+struct _GArrowTrimOptionsPrivate
+{
+ gchar *characters;
+};
+
+G_DEFINE_TYPE_WITH_PRIVATE(GArrowTrimOptions,
+ garrow_trim_options,
+ GARROW_TYPE_FUNCTION_OPTIONS)
+
+#define GARROW_TRIM_OPTIONS_GET_PRIVATE(object)
\
+ static_cast<GArrowTrimOptionsPrivate *>(
\
+ garrow_trim_options_get_instance_private(GARROW_TRIM_OPTIONS(object)))
+
+static void
+garrow_trim_options_dispose(GObject *object)
+{
+ auto priv = GARROW_TRIM_OPTIONS_GET_PRIVATE(object);
+ if (priv->characters) {
+ g_free(priv->characters);
+ priv->characters = nullptr;
+ }
+ G_OBJECT_CLASS(garrow_trim_options_parent_class)->dispose(object);
+}
+
+static void
+garrow_trim_options_set_property(GObject *object,
+ guint prop_id,
+ const GValue *value,
+ GParamSpec *pspec)
+{
+ auto options = garrow_trim_options_get_raw(GARROW_TRIM_OPTIONS(object));
+ auto priv = GARROW_TRIM_OPTIONS_GET_PRIVATE(object);
+
+ switch (prop_id) {
+ case PROP_TRIM_OPTIONS_CHARACTERS:
+ {
+ const gchar *characters = g_value_get_string(value);
+ if (priv->characters) {
+ g_free(priv->characters);
+ }
+ priv->characters = g_strdup(characters);
+ options->characters = characters ? characters : "";
+ }
Review Comment:
Can we simplify this?
```suggestion
options->characters = g_value_get_string(value);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
