Pranav2612000 commented on PR #3844: URL: https://github.com/apache/arrow-adbc/pull/3844#issuecomment-3701963561
> I think we can remove the `#[cfg]` and just have this behavior on all platforms (maybe it doesn't work on Windows?) Yeah. Libloading does have separate definitions for windows and unix ( https://github.com/nagisa/rust_libloading/blob/dab97c569b33bd515e16637b8dedbdc696d9ec9c/src/safe.rs#L6 ). While we get the changes merged upstream, I'm updating this PR to mirror this - cfg conditions on whether the os is windows or unix ( rather than on mac ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
