tustvold commented on code in PR #9077:
URL: https://github.com/apache/arrow-rs/pull/9077#discussion_r2655647015
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1180,41 +1193,6 @@ fn write_leaf(writer: &mut ColumnWriter<'_>, levels:
&ArrayLevels) -> Result<usi
.unary::<_, Int32Type>(|v| v.as_i128() as i32);
write_primitive(typed, array.values(), levels)
}
- ArrowDataType::Dictionary(_, value_type) => match
value_type.as_ref() {
Review Comment:
We instead lift this into the ArrowColumnWriter::write method which not only
cuts down on duplication, but ensures we treat dictionary and non-dictionary
values equivalently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
