sebbASF commented on PR #48624: URL: https://github.com/apache/arrow/pull/48624#issuecomment-3702531734
From https://github.com/apache/arrow/issues/48623#issuecomment-3701336827 > > It looks as though all the headers can (and should) be populated in the ReportUtils.send_email method. > > Could you explain the reason? If we use the approach, it's (a bit) difficult to implement dry-run. (We need to pass more arguments to `ReportUtils.send_email`.) > At present, the headers have to be generated in lots of places, which means more maintenance and more testing. As to doing a dry-run, that depends on whether you need to see all the headers or just the body. The Python email library builds up the message for sending, and you can just print the message instead of sending it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
