kou commented on PR #48491: URL: https://github.com/apache/arrow/pull/48491#issuecomment-3703155759
> That makes sense, but we are already using GHashTable for the field metadata, so I thought that was fine: > > https://github.com/apache/arrow/blob/43273fde11aae439df7f0c7034f8dfaf9b2bc661/c_glib/arrow-glib/field.cpp#L328-L329 Ah, I understand. `GHashTable` is acceptable because there is the `(element-type KTYPE VTYPE)` annotation: https://gi.readthedocs.io/en/latest/annotations/giannotations.html#type-signature But `GPtrArray<GHashTable>` should be avoided. > I think I need to give up on the idea that I can generate code for all functions. How about this: > > * Provide garrow_make_struct_options_add_field() in GLib > > * Remove the `field-names` property to avoid inconsistency > > * Provide `Arrow::MakeStructOptions#try_convert` as you suggested earlier > > * In my code: Override the `make_struct` function with a specific implementation Thanks for the suggestion. Let's use the approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
