hypsakata commented on code in PR #48699:
URL: https://github.com/apache/arrow/pull/48699#discussion_r2656179427
##########
ruby/red-arrow/lib/arrow/array-builder.rb:
##########
@@ -186,6 +199,34 @@ def create_builder(builder_info)
data_type = Decimal256DataType.new(builder_info[:precision],
builder_info[:scale])
Decimal256ArrayBuilder.new(data_type)
+ when :int
+ required_bit_length = builder_info[:bit_length] + 1
Review Comment:
I agree with your suggestion. Checking against defined constants
(`GLib::MININT*` / `GLib::MAXINT*`) is more readable than calculating bit
lengths. I will update the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
