paleolimbot commented on code in PR #3852:
URL: https://github.com/apache/arrow-adbc/pull/3852#discussion_r2658715028
##########
r/adbcsqlite/tests/testthat/test-adbcsqlite-package.R:
##########
@@ -99,6 +99,25 @@ test_that("read/write/execute SQL work with sqlite
connections", {
adbcdrivermanager::adbc_database_release(db)
})
+test_that("write_adbc() supports catalog_name", {
+ db <- adbc_database_init(adbcsqlite())
+ con <- adbc_connection_init(db)
+ on.exit({
+ adbcdrivermanager::adbc_connection_release(con)
+ adbcdrivermanager::adbc_database_release(db)
+ })
+
+ df <- data.frame(x = as.double(1:3))
+ expect_identical(
+ adbcdrivermanager::write_adbc(df, con, "df_catalog", catalog_name =
"main", mode = "replace"),
+ df
+ )
+
+ stream <- adbcdrivermanager::read_adbc(con, "SELECT * from main.df_catalog")
+ expect_identical(as.data.frame(stream), df)
+ stream$release()
Review Comment:
```suggestion
```
(In theory `as.data.frame()` will release the stream)
##########
r/adbcdrivermanager/R/helpers.R:
##########
@@ -30,6 +30,10 @@
#' @param mode One of `"create"`, `"append"`, `"replace"`, `"create_append"`
(error if the schema
#' is not compatible or append otherwise), or `"default"` (use the
`adbc.ingest.mode`
#' argument of [adbc_statement_init()]). The default is `"default"`.
+#' @param catalog_name If not `NULL`, the catalog to create/locate the table
in.
+#' **This API is EXPERIMENTAL.**
Review Comment:
I'm not sure I particularly mind the extra .svgs, although I think the
all-caps gets the point across just as nicely here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
