Dandandan commented on a change in pull request #54:
URL: https://github.com/apache/arrow-datafusion/pull/54#discussion_r620393800
##########
File path: datafusion/src/datasource/csv.rs
##########
@@ -46,10 +47,17 @@ use crate::physical_plan::csv::CsvExec;
pub use crate::physical_plan::csv::CsvReadOptions;
use crate::physical_plan::{common, ExecutionPlan};
+enum Source {
+ /// Path to a single CSV file or a directory containing one of more CSV
files
+ Path(String),
+
+ /// Read CSV data from a reader
+ Reader(Mutex<Option<Box<dyn Read + Send + Sync + 'static>>>),
Review comment:
Also I am wondering, if we do it like this, we would we need to do the
same for json/xml/etc sources that should support essentially the same to avoid
reimplementing it for each format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
