pitrou commented on code in PR #48601: URL: https://github.com/apache/arrow/pull/48601#discussion_r2662240237
########## cpp/src/arrow/util/chrono_internal.h: ########## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +/// \file chrono_internal.h +/// \brief Abstraction layer for C++20 chrono calendar/timezone APIs +/// +/// This header provides a unified interface for chrono calendar and timezone +/// functionality. On compilers with full C++20 chrono support, it uses +/// std::chrono. On other compilers, it falls back to the vendored Howard Hinnant +/// date library. +/// +/// The main benefit is on Windows where std::chrono uses the system timezone +/// database, eliminating the need for users to install IANA tzdata separately. + +#include <chrono> +#include <string> +#include <string_view> + +// Feature detection for C++20 chrono timezone support +// We only enable for compilers with FULL support (not partial) +// https://en.cppreference.com/w/cpp/compiler_support/20.html#cpp_lib_chrono_201907L +// +// MSVC 19.29+ (VS16.10+): Full C++20 chrono support, uses Windows internal TZ database. +// GCC libstdc++ has a bug where DST state is incorrectly reset when a timezone Review Comment: Can you add a link to the upstream issue now we know there's one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
