paleolimbot commented on code in PR #8524:
URL: https://github.com/apache/arrow-rs/pull/8524#discussion_r2662581094
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -490,6 +498,18 @@ impl ArrowWriterOptions {
..self
}
}
+
+ /// Explicitly specify the Parquet schema to be used
Review Comment:
I put a note on the other PR as well, but the intention was really just to
be able to add the test that I needed to add at the time.
I don't have opinions about how this kind of thing should work here in
particular, but a schema request across a type boundary (e.g.
`pyarrow.table(xxx, schema=xxx)` is quite common and nicely separates the
destination type inference (usually lossy with some choices to be made) from
the conversion (either write the source type or error if this is not possible).
The API here was basically an escape hatch in the event that the built-in
Parquet schema inference did the wrong thing (which it did for spatial types at
the time that I added it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
