EnricoMi commented on code in PR #48709:
URL: https://github.com/apache/arrow/pull/48709#discussion_r2664591058
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -4237,4 +4237,69 @@ TEST_F(TestHalfFloatBuilder, TestBulkAppend) {
}
}
+class TestDayTimeIntervalBuilder : public ::testing::Test {
+ public:
+ void VerifyValue(const DayTimeIntervalBuilder& builder, int64_t index,
+ DayTimeIntervalType::DayMilliseconds expected) {
+ ASSERT_EQ(builder.GetValue(index), expected);
+ ASSERT_EQ(builder[index], expected);
+ }
+};
+
+TEST_F(TestDayTimeIntervalBuilder, TestAppend) {
+ DayTimeIntervalBuilder builder;
+ DayTimeIntervalType::DayMilliseconds value1{1, 100};
+ DayTimeIntervalType::DayMilliseconds value2{3, 200};
+ DayTimeIntervalType::DayMilliseconds value3{5, 300};
+
+ ASSERT_OK(builder.Append(value1));
+ ASSERT_OK(builder.Append(value2));
+ ASSERT_OK(builder.AppendNull());
+ ASSERT_OK(builder.Reserve(3));
+ builder.UnsafeAppend(value3);
+
+ VerifyValue(builder, 0, value1);
+ VerifyValue(builder, 1, value2);
+ VerifyValue(builder, 3, value3);
Review Comment:
Shall we assert value 2 of builder is null? Does `builder` provide access to
null values?
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -4237,4 +4237,69 @@ TEST_F(TestHalfFloatBuilder, TestBulkAppend) {
}
}
+class TestDayTimeIntervalBuilder : public ::testing::Test {
+ public:
+ void VerifyValue(const DayTimeIntervalBuilder& builder, int64_t index,
+ DayTimeIntervalType::DayMilliseconds expected) {
+ ASSERT_EQ(builder.GetValue(index), expected);
+ ASSERT_EQ(builder[index], expected);
+ }
+};
+
+TEST_F(TestDayTimeIntervalBuilder, TestAppend) {
+ DayTimeIntervalBuilder builder;
+ DayTimeIntervalType::DayMilliseconds value1{1, 100};
+ DayTimeIntervalType::DayMilliseconds value2{3, 200};
+ DayTimeIntervalType::DayMilliseconds value3{5, 300};
+
+ ASSERT_OK(builder.Append(value1));
+ ASSERT_OK(builder.Append(value2));
+ ASSERT_OK(builder.AppendNull());
+ ASSERT_OK(builder.Reserve(3));
+ builder.UnsafeAppend(value3);
+
+ VerifyValue(builder, 0, value1);
+ VerifyValue(builder, 1, value2);
+ VerifyValue(builder, 3, value3);
+
+ ASSERT_OK_AND_ASSIGN(auto array, builder.Finish());
+ ASSERT_TRUE(array->IsNull(2));
+}
Review Comment:
Shouldn't we test the non-null values of `array`as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
